JuliaSmoothOptimizers / LDLFactorizations.jl

Factorization of Symmetric Matrices
GNU Lesser General Public License v3.0
34 stars 12 forks source link

Change precision selection API #122

Closed geoffroyleconte closed 1 year ago

geoffroyleconte commented 1 year ago

This PR is breaking. I've copied the changes of https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/72. The permutation P is now a keyword argument. Tf can be specified with a new method.

I've also removed the ldl_analyze, ldl, and ldl_factorized! docs of the wrappers loop to avoid duplicating the documentation.

Needs https://github.com/JuliaSmoothOptimizers/LDLFactorizations.jl/pull/121 first.

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.17% // Head: 98.63% // Increases project coverage by +0.45% :tada:

Coverage data is based on head (e5128ff) compared to base (097d0fe). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #122 +/- ## ========================================== + Coverage 98.17% 98.63% +0.45% ========================================== Files 1 1 Lines 438 438 ========================================== + Hits 430 432 +2 + Misses 8 6 -2 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/LDLFactorizations.jl/pull/122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/LDLFactorizations.jl](https://codecov.io/gh/JuliaSmoothOptimizers/LDLFactorizations.jl/pull/122/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0xETEZhY3Rvcml6YXRpb25zLmps) | `98.63% <100.00%> (+0.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago
Package name latest stable
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
RipQP.jl
github-actions[bot] commented 1 year ago
Package name latest stable
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
RipQP.jl