codecov[bot]
commented
2 years ago Codecov Report
Base: 83.82% // Head: 85.99% // Increases project coverage by +2.16% :tada:
Coverage data is based on head (
94da186) compared to base (beecb91). Patch coverage: 98.64% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 83.82% 85.99% +2.16% ========================================== Files 1 1 Lines 303 357 +54 ========================================== + Hits 254 307 +53 - Misses 49 50 +1 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/LimitedLDLFactorizations.jl](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/58/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0xpbWl0ZWRMRExGYWN0b3JpemF0aW9ucy5qbA==) | `85.99% <98.64%> (+2.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
All the elements of
adiagshould keep their sign.LLDL.Lnow allocates in order to keep the existing behaviour but I can change it to something likeif that is an issue.