Closed geoffroyleconte closed 2 years ago
Base: 85.99% // Head: 88.20% // Increases project coverage by +2.20%
:tada:
Coverage data is based on head (
487d28f
) compared to base (83b91a5
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for the reviews!
The matrix used by the factorization is now lower triangular with the diagonal, instead of being separated in a strict lower triangular matrix and the diagonal elements.
The
lldl
andLimitedLDLFactorization
function arguments have been modified to be more convenient to use with these changes. In particular, the permutation vectorP
is now a keyword argument.adiag
was previously computed withdiag(A)
, which produces aSparseVector
. It is now aVector
that may have some zeros, because I thought it would be faster to access its elements. This change forces the types ofpos
andneg
to be alwaysInt64
because they are computed withfindall
, but I don't think this is an issue.