search

JuliaSmoothOptimizers / LimitedLDLFactorizations.jl

Limited-Memory Factorization of Symmetric Matrices
Other
21 stars 10 forks source link

Reset work vectors when lldl attempt failed #71

Closed geoffroyleconte closed 2 years ago

geoffroyleconte commented 2 years ago

The bug was due to some work arrays that were not reset to zero after attempt_lldl! failed. In this case, α and d were also not updated, so I decided to fix α to α_min = sqrt(eps(Tv)) if there is a failure. I lowered the value of α_min because I had better results when calling gmres with the LLDL preconditioner.

codecov[bot] commented 2 years ago

Codecov Report

Base: 88.20% // Head: 88.23% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (9ad0aa9) compared to base (1eb5633). Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== + Coverage 88.20% 88.23% +0.03% ========================================== Files 1 1 Lines 373 374 +1 ========================================== + Hits 329 330 +1 Misses 44 44 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/LimitedLDLFactorizations.jl](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/71/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0xpbWl0ZWRMRExGYWN0b3JpemF0aW9ucy5qbA==) | `88.23% <80.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dpo commented 2 years ago

Does this fix #57 ?

geoffroyleconte commented 2 years ago

Does this fix #57 ?

Yes.