Closed geoffroyleconte closed 2 years ago
Base: 88.23% // Head: 88.20% // Decreases project coverage by -0.03%
:warning:
Coverage data is based on head (
ad626b2
) compared to base (0ab4769
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head ad626b2 differs from pull request most recent head db21f73. Consider uploading reports for the commit db21f73 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ok, so if I understand the idea is that you can compute a factorization in Tf
type while A
is of type T
?
Have you checked the type stability of the example you gave with @code_warntype?
@tmigot @dpo there were indeed some type instabilities but I fixed it with my latest commit. I added a new method in case we want a lower-precision factorization. I think I will have to make similar changes in LDLFactorizations.jl.
Choose the precision of the factorization with
Tf
. Remove type parameterization of solve functions.