search

JuliaSmoothOptimizers / LimitedLDLFactorizations.jl

Limited-Memory Factorization of Symmetric Matrices
Other
21 stars 10 forks source link

Change Real to Number #79

Open geoffroyleconte opened 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.91% // Head: 88.91% // No change to project coverage :thumbsup:

Coverage data is based on head (2d747e8) compared to base (51eec8d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ======================================= Coverage 88.91% 88.91% ======================================= Files 1 1 Lines 388 388 ======================================= Hits 345 345 Misses 43 43 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/LimitedLDLFactorizations.jl](https://codecov.io/gh/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0xpbWl0ZWRMRExGYWN0b3JpemF0aW9ucy5qbA==) | `88.91% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dpo commented 1 year ago

Could we just leave Tf as an (unspecified) parameter?

geoffroyleconte commented 1 year ago

Probably, the only issue would be that if there is an error because of Tf, it would be more difficult to debug (for example I don't know if this would work directly for complex numbers). If you think that it's fine, I can open a PR.

dpo commented 1 year ago

As you pointed out earlier, we need to use conj in appropriate places to ensure correctness, but I think I would leave Tf free.