Closed geoffroyleconte closed 1 year ago
Base: 97.38% // Head: 97.42% // Increases project coverage by +0.03%
:tada:
Coverage data is based on head (
2b9fa2b
) compared to base (f2fe71c
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Following https://github.com/JuliaSmoothOptimizers/NLPModelsModifiers.jl/pull/94, I added
reset!
functions that restore the QN operators to the identity operator.At the same time, I spotted a bug with
SpectralGradient
where the push was not updatingd
in the closureprod = (res, v, α, β) -> mulSquareOpDiagonal!(res, d, v, α, β)
(becaused
was a Real). I fixed it by changingd
to[σ]
so that modifyingd[1]
modifiesmulSquareOpDiagonal!(res, d, v, α, β)
accordingly.This modifies the way we update a
SpectralGradient
: we have to doop.d[1] = 2.0
instead ofop.d = 2.0
, but since we are supposed to update this operator withpush!
, this should not break code.Does the adding of the
reset!
function requires a new minor release2.6.0
, or can we stick to a patch2.5.1
?