search

JuliaSmoothOptimizers / LinearOperators.jl

Linear Operators for Julia
Other
149 stars 31 forks source link

[breaking] Remove shape function (duplicate of size) #297

Closed JakobAsslaender closed 7 months ago

JakobAsslaender commented 8 months ago

Hi everyone,

we have encountered in several of our packages a conflict between the functions LinearOperators.shape and Distributions.shape (https://github.com/JuliaImageRecon/LinearOperatorCollection.jl/issues/3#issuecomment-1822917316). Since the former is a duplicate of size, I was wondering if it would be feasible to drop shape from this package. To make everyone's life easier, I put those changes in a PR.

This change would be breaking as we would drop an exported function. But fixes in other packages should be straight forward with a search & replace.

Many thanks for considering!

github-actions[bot] commented 7 months ago
Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl
JakobAsslaender commented 7 months ago

Solves #298

JakobAsslaender commented 7 months ago

The failed test is due to missing compat declaration of packages shipped Base. I presume that this PR is not right place to rectify this, is it?

JeffFessler commented 7 months ago

Oops, needs a version bump in Project.toml