Closed geoffroyleconte closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5ce0dc0
) 96.58% compared to head (7db0139
) 96.58%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
(LinearOperators) pkg> st
ERROR: Compat `ChainRulesCore` not listed in `deps` or `extras` section.
Should I move it to extras?
@geoffroyleconte I wasn't sure, so I tried something. The hack to keep maintaining Julia 1.6 is to keep the extras section for weak deps.
That's a bit weird to have a separate .toml in the tests no? We could keep my initial commit, I don't think there is an effect on performance? Also, do you know why the documentation fails here?
That's a bit weird to have a separate .toml in the tests no? We could keep my initial commit, I don't think there is an effect on performance? Also, do you know why the documentation fails here?
I know Julia have pushing for this for a while, see https://pkgdocs.julialang.org/v1/creating-packages/#Adding-tests-to-the-package for instance even though both approaches are still supported. I think it helps maintability to keep compatibility of versions used (even though it means we have to update these compatibility constraints sometimes). This is not related to performance, but making sure it fits in the Julia eco-system.
No clue for the documentation, it seems everytime a PR has more than one commit it does this...
Yes, it's true, and it seems this comment is here since version 1.2... but I still think it makes sense to have compat for tests. Even more now, that base packages have versions. On the other side, I agree that it is slightly annoying to maintain 3 Project.toml per package (normal, test and doc)
There are issues with Aqua because there are no deps declared for ChainRulesCore:
@tmigot