search

JuliaSmoothOptimizers / LinearOperators.jl

Linear Operators for Julia
Other
149 stars 31 forks source link

Version 2.7.0 is breaking (though the version might indicate it is not) – DiagonalQN used in other packages. #319

Closed kellertuer closed 4 months ago

kellertuer commented 5 months ago

Hi, As I reported here https://github.com/JuliaSmoothOptimizers/QuadraticModels.jl/issues/122

our CI broke. I could narrow it down to https://github.com/JuliaSmoothOptimizers/NLPModelsModifiers.jl loading LinearOperators.jl and using DiagonalQN.

This was removed in 2.7, though that should have been kept in a non-breaking version. Maybe it would be nice to have it at least only deprecated? This package seems to be used in quite some places, so having this break in a non-breaking version might be a bit dangerous.

kellertuer commented 5 months ago

For my case this might be resolved soon-ish; so this can also be closed then (I would just favour if you could be a bit more careful next time then).

dpo commented 4 months ago

Thanks @kellertuer ! Will do!