search

JuliaSmoothOptimizers / MUMPS.jl

A Julia Interface to MUMPS
Other
42 stars 14 forks source link

Test local install #103

Closed dpo closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 19.94% // Head: 19.94% // No change to project coverage :thumbsup:

Coverage data is based on head (d129b3c) compared to base (63bfdeb). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ======================================= Coverage 19.94% 19.94% ======================================= Files 6 6 Lines 777 777 ======================================= Hits 155 155 Misses 622 622 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dpo commented 2 years ago

It's hard to know if the external library is being used or not. The info message doesn't show. I tried using MUMPS before using Test, but that didn't show anything either.

dpo commented 2 years ago

don't force-push until finalized; otherwise we can't see what you changed.

amontoison commented 2 years ago

don't force-push until finalized; otherwise we can't see what you changed.

I just rebased. I don't force-push otherwise.

amontoison commented 2 years ago

It's hard to know if the external library is being used or not. The info message doesn't show. I tried using MUMPS before using Test, but that didn't show anything either.

The external library is not used: https://github.com/JuliaSmoothOptimizers/MUMPS.jl/runs/8006282188?check_suite_focus=true#step:6:103.

amontoison commented 2 years ago

I was looking a CI_M1 build instead of a CI-Homebrew build.... The issue was between the screen and the chair :) The custom installation works fine. I just added a constant MUMPS_INSTALLATION to easily see if we have custom installation or not in the tests.

dpo commented 2 years ago

Excellent, thank you!