search

JuliaSmoothOptimizers / MUMPS.jl

A Julia Interface to MUMPS
Other
42 stars 14 forks source link

PR 47 rebased, updated for MUMPS 5.4.1 #64

Closed dpo closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5e09c3c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage        ?   19.38%           
=======================================
  Files           ?       10           
  Lines           ?      908           
  Branches        ?        0           
=======================================
  Hits            ?      176           
  Misses          ?      732           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e09c3c...437013a. Read the comment docs.

dpo commented 2 years ago

As long as you only add to the end of the struct, it's ok. There are lots of questions in #46 .

dpo commented 2 years ago

I fixed a bunch of things, mostly related to return values. Should be getting close now.

dpo commented 2 years ago

@amontoison Still approve with the latest changes?

amontoison commented 2 years ago

@amontoison Still approve with the latest changes?

Yes! You can merge the PR.