search

JuliaSmoothOptimizers / NLPModels.jl

Data Structures for Optimization Models
Other
172 stars 35 forks source link

NLSModels should be considered equal to NLPModels #127

Closed vepiteski closed 4 years ago

vepiteski commented 6 years ago

I want to include some NLSModels in a test suite for algorithms optimizing general NLPModels. I use as a stopping criterion the counters. I have to struggle to make my stopping test (tired) compatible with Counters and NLSCounters.

There should be a field counters::Counters in ALL NLPModels. If the NLSModels use a further set of counters, it should be an additionnal feature, not required in my comparisons.

abelsiqueira commented 6 years ago

This won't be a problem after #109, though it may take some time to do that.

For now, though, I recommend using neval_obj(nlp) and similar which gets the correct counter.

dpo commented 6 years ago

Yes, it's recommended to use the API to access the counters rather than accessing them directly. Does that solve the issue?

abelsiqueira commented 4 years ago

Using the counters API should fix it, so I'm closing this.