Add support for the new NL interface

JuliaSmoothOptimizers / NLPModelsJuMP.jl

Create NLPModels with JuMP

Other

34 stars 8 forks source link

Add support for the new NL interface #171

Closed blegat closed 10 months ago

blegat commented 10 months ago

Closes https://github.com/JuliaSmoothOptimizers/NLPModelsJuMP.jl/issues/160

github-actions[bot] commented 10 months ago

Package name	latest	stable
NLSProblems.jl
OptimizationProblems.jl

abelsiqueira commented 10 months ago

Thanks for the PR. I looked in the logs and found this small type. Maybe that is the only issue, but to be honest it's way beyond my pay grade. It would be nice to have a test with JuMP 1.15 nonlinear syntax as well if you have the time.

blegat commented 10 months ago

Because we run MOI.Test.runtests and we now declare that we support ScalarNonlinearFunction, it should automatically now run with tests in MOI.ScalarNonlinearFunction

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
src/MOI_wrapper.jl	`89.39% <100.00%> (+0.16%)`	:arrow_up:
src/utils.jl	`94.88% <97.22%> (+0.20%)`	:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

abelsiqueira commented 10 months ago

Release 0.12.5 includes this.

tmigot commented 10 months ago

Thanks @blegat and @abelsiqueira that looks great!