JuliaSmoothOptimizers / NLPModelsJuMP.jl

Create NLPModels with JuMP
Other
34 stars 8 forks source link

Support quadratic constraints #181

Closed amontoison closed 2 months ago

amontoison commented 2 months ago

close #50 close #149 close #150 @tmigot You should be happy now :smiley:

github-actions[bot] commented 2 months ago
Package name latest stable
NLSProblems.jl
OptimizationProblems.jl
amontoison commented 2 months ago

@tmigot We should probably add HS61, HS100 and HS219 in NLPModelsTest.jl for more robust tests.

amontoison commented 2 months ago

If we replace @NLconstraint with @constraint for the quadratic constraints in hs6, hs10, hs11, and hs14, almost all tests pass. The failing tests are related to this issue: JuliaSmoothOptimizers/NLPModelsTest.jl#109.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 74.27653% with 80 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (5bb0b82) to head (02317b4).

:exclamation: Current head 02317b4 differs from pull request most recent head f39f1e4

Please upload reports for the commit f39f1e4 to get more accurate results.

Files Patch % Lines
src/utils.jl 57.28% 44 Missing :warning:
src/moi_nls_model.jl 65.04% 36 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== - Coverage 93.00% 86.94% -6.07% ========================================== Files 4 5 +1 Lines 629 919 +290 ========================================== + Hits 585 799 +214 - Misses 44 120 +76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.