search

JuliaSmoothOptimizers / NLPModelsModifiers.jl

Other
9 stars 9 forks source link

update diagonal QN models #107

Closed dpo closed 8 months ago

dpo commented 8 months ago

This update follows an update of diagonal QN operators in LinearOperators.jl.

See https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/pull/316

dpo commented 8 months ago

@tmigot Is there a reason for the SpectralGradientModel to exist separately from DiagonalQNModel? It’s just a special case.

github-actions[bot] commented 8 months ago
Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl
github-actions[bot] commented 8 months ago
Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl
github-actions[bot] commented 8 months ago
Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl
tmigot commented 8 months ago

There was no specific reason, and I think your PR clarifies it. The changes look for me, and running locally the tests are passing. So, we just need a new (breaking) release of LinearOperators.jl after https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/pull/316

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.40%. Comparing base (1f127a9) to head (26dd0f3). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ======================================= Coverage 97.40% 97.40% ======================================= Files 6 6 Lines 887 888 +1 ======================================= + Hits 864 865 +1 Misses 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago
Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl
dpo commented 8 months ago

I believe the AmplNLReader failure should go away after this PR has been merged.