JuliaSmoothOptimizers / PartitionedVectors.jl

Other
8 stars 1 forks source link

Add a warning when no element contribute to a variable #25

Closed paraynaud closed 1 year ago

paraynaud commented 1 year ago

@dpo small changes to get a warning if no element contribute to a variable. example:

$$ f(x) = f_1(x_1,x2) + f(x_4, x_5) $$

no element contribute to $x_3$. But it worsen the performance when it happens, what do you prefer?

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.95% // Head: 98.96% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (2c92a12) compared to base (97dc13f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================== + Coverage 98.95% 98.96% +0.01% ========================================== Files 6 6 Lines 192 194 +2 ========================================== + Hits 190 192 +2 Misses 2 2 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/struct.jl](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3N0cnVjdC5qbA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.