JuliaSmoothOptimizers / PartitionedVectors.jl

Other
8 stars 1 forks source link

Keyword argument to disable @warn from `build!` #27

Closed paraynaud closed 1 year ago

paraynaud commented 1 year ago

@dpo I added this keyword argument to disable warning from build! consequently to #25. I did not change default behaviour of build!, which warns when no element contribute to a variable. I made this change because it is really convenient for me to use

N = 1500
n = 20000
nie = 50
element_variables = map((i -> sample(1:n, nie, replace = false)), 1:N)

pv = PartitionedVector(element_variables)

to define a large PartitionedVector. It is usefull to push the limits of PartitionedVectors. Unfortunately, I can't ensure that element_variables get every component between 1:n, that why I added the keyword argument.

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.07% // Head: 99.07% // No change to project coverage :thumbsup:

Coverage data is based on head (df6a97b) compared to base (c58ce9d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ======================================= Coverage 99.07% 99.07% ======================================= Files 6 6 Lines 217 217 ======================================= Hits 215 215 Misses 2 2 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/base.jl](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2Jhc2Uuamw=) | `98.11% <100.00%> (ø)` | | | [src/krylov.jl](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2tyeWxvdi5qbA==) | `98.63% <100.00%> (ø)` | | | [src/linearAlgebra.jl](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2xpbmVhckFsZ2VicmEuamw=) | `100.00% <100.00%> (ø)` | | | [src/struct.jl](https://codecov.io/gh/JuliaSmoothOptimizers/PartitionedVectors.jl/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3N0cnVjdC5qbA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.