Closed RenanOD closed 4 years ago
Thanks!
What do you mean by "concurrency"?
I think it's supposed to be "consistency"?
Was a bad choice of word :crying_cat_face: I'll changed it to consistency.
A ADNLPModel is created using ForwardDiff, then a QuadraticModel is built using it. These tests check that the derivatives, objective and constraints are consistent between both models.
Merging #10 into master will increase coverage by
41.93%
. The diff coverage is58.33%
.
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 40.67% 82.6% +41.93%
==========================================
Files 3 3
Lines 59 46 -13
==========================================
+ Hits 24 38 +14
+ Misses 35 8 -27
Impacted Files | Coverage Δ | |
---|---|---|
src/qpmodel.jl | 83.72% <58.33%> (+44.43%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6e92639...01e69fd. Read the comment docs.
Ready for review.
All requested changes were made.
I made the requested changes and checked with NLPModels to remove all unnecessary kwargs and methods. Ready for review.
Thank you for all this! We'll have to think some more about this package because H can be an explicit matrix or an operator, while A must be an explicit matrix. We should allow more flexibility and have ways to distinguish the different cases.
Thank you for all this! We'll have to think some more about this package because H can be an explicit matrix or an operator, while A must be an explicit matrix. We should allow more flexibility and have ways to distinguish the different cases.
Should we leave for a second PR? It looks very easy to add opA
the same way we have opH
. Are you thinking something else?
BTW, LLSModel in NLPModels.jl also does this/needs attention.
No, that should be done in other PRs.
I moved this to #13 and removed the IPOPT tests.
:tada: :tada: :tada: