JuliaSmoothOptimizers / QuadraticModels.jl

Data structures for linear and quadratic optimization problems based on NLPModels.jl
Other
16 stars 10 forks source link

Precompilation on CI fails since today: `DiagonalQN` not defined #122

Closed kellertuer closed 8 months ago

kellertuer commented 8 months ago

Hi, thanks for this nice package. We use the package as a (weak) dependency for one of our sub solvers in Manopt.jl that we currently finalise.

Today it started failing on CI with

Failed to precompile QuadraticModels [f468eda6-eac5-11e8-05a5-ff9e497bcd19] to "/home/runner/.julia/compiled/v1.10/QuadraticModels/jl_kb6naG".
ERROR: LoadError: UndefVarError: `DiagonalQN` not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/NLPModelsModifiers/IMwDI/src/quasi-newton.jl:29
[...]

cf. https://github.com/JuliaManifolds/Manopt.jl/actions/runs/8064457138/job/22028375264 for the full trace. Maybe that is even a dependency of yours failing?

tmigot commented 8 months ago

Hey @kellertuer ! We had a relatively major update yesterday on a core package, and version are being updated. Did the PR solved your problem? Do you have version compatibility for this package?

kellertuer commented 8 months ago

I will have to wait for this one being registered and such. For now I added LinearOperators.jl as a dependency and fixed it to 2.6 (since from 2.7 it broke, but that is not a breaking version number). I can report as soon as this new combat update in the PR is available as a version.

edit: I have QuadraticModels as a weak dependency, so I should be able to only allow 0.9.6 and newer, which hopefully fixes it; I do not have NLPModellsModifiers now LInearOperators as dependencies, which exactly cause the problem here then. Will report soon-ish ;)

kellertuer commented 8 months ago

Just checked with 0.9.6 – it works fine again! Thanks for the quick fix.

Edit: Hm, the CI still fails on this, will further investigate.

kellertuer commented 8 months ago

This one seems to still fail and I am not so sure why

https://github.com/JuliaManifolds/Manopt.jl/actions/runs/8065956531/job/22034343468#step:6:637

kellertuer commented 8 months ago

It might be that something like RipQP or so needs that update as well (version bump I mean)? For now something keeps NLModelsModifiers to still use 0.6.x which is incompatible with LinearOperators.jl 2.7