Closed RenanOD closed 5 years ago
Merging #7 into master will increase coverage by
36.9%
. The diff coverage is53.84%
.
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 3.77% 40.67% +36.9%
==========================================
Files 3 3
Lines 53 59 +6
==========================================
+ Hits 2 24 +22
+ Misses 51 35 -16
Impacted Files | Coverage Δ | |
---|---|---|
src/QuadraticModels.jl | 100% <ø> (ø) |
:arrow_up: |
src/qpmodel.jl | 39.28% <53.84%> (+39.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c55e641...a8f5ecf. Read the comment docs.
Ready for review.
Thanks, I made the corrections.
I thought about adding another test that would download a qps file, use qpsreader, convert to quadraticmodel, solve it and check the solution. Then this package would depend on QPSReader.jl and I'm not sure if that's ok. What do you think?
I think that would be fine! Thank you!
I changed my mind and believe this PR should be merged as is and if possible released. That's because QPSReader isn't released yet and its tests will require this PR.
So tests with qps should be added here only after QPSReader is released. I'm currently working on it https://github.com/JuliaSmoothOptimizers/QPSReader.jl/pull/6 .
I find it awkward how these packages will depend on each other. Hope it's ok. oO
Maybe the kwargs and obj_weight changes can be left for a follow-up PR with consistency checks? @dpo, do you agree?
Sure, could you open an issue?
Ready for review.
I made the changes requested by @abelsiqueira, except for the kwargs
s and obj_weight
s.
Thank you.
This should update QuadraticModels according to recent NLPModels changes. The construction of a QuadraticModel and its solution using NLPModelsIpopt was added as test.