JuliaSmoothOptimizers / RipQP.jl

MIT License
29 stars 5 forks source link

HSL MA57 and MA97 CI #260

Closed geoffroyleconte closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 78.41% // Head: 81.48% // Increases project coverage by +3.06% :tada:

Coverage data is based on head (69ab12b) compared to base (23e70a0). Patch coverage: 64.70% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #260 +/- ## ========================================== + Coverage 78.41% 81.48% +3.06% ========================================== Files 53 54 +1 Lines 3331 3332 +1 ========================================== + Hits 2612 2715 +103 + Misses 719 617 -102 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/RipQP.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL1JpcFFQLmps) | `96.29% <ø> (-0.03%)` | :arrow_down: | | [...olvers/sparse\_fact\_utils/abstract-factorization.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvc29sdmVycy9zcGFyc2VfZmFjdF91dGlscy9hYnN0cmFjdC1mYWN0b3JpemF0aW9uLmps) | `85.18% <ø> (+29.62%)` | :arrow_up: | | [...ations/solvers/sparse\_fact\_utils/ma97fact\_utils.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvc29sdmVycy9zcGFyc2VfZmFjdF91dGlscy9tYTk3ZmFjdF91dGlscy5qbA==) | `69.23% <ø> (ø)` | | | [...ations/solvers/sparse\_fact\_utils/ma57fact\_utils.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvc29sdmVycy9zcGFyc2VfZmFjdF91dGlscy9tYTU3ZmFjdF91dGlscy5qbA==) | `62.50% <62.50%> (ø)` | | | [src/data\_initialization.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2RhdGFfaW5pdGlhbGl6YXRpb24uamw=) | `93.33% <100.00%> (+8.41%)` | :arrow_up: | | [src/scaling.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3NjYWxpbmcuamw=) | `89.96% <0.00%> (+2.58%)` | :arrow_up: | | [src/iterations/regularization.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvcmVndWxhcml6YXRpb24uamw=) | `48.48% <0.00%> (+3.03%)` | :arrow_up: | | [src/iterations/solvers/augmented/K2LDL.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvc29sdmVycy9hdWdtZW50ZWQvSzJMREwuamw=) | `96.26% <0.00%> (+23.83%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/260/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

geoffroyleconte commented 2 years ago

@amontoison do you know why the tests with ma97 fail on julia 1.6? Here is the error message:

Got exception outside of a @test
  could not load library "/Users/administrator/.julia/packages/HSL/X5ozr/deps/usr/lib/libhsl_ma97.dylib"
  dlopen(/Users/administrator/.julia/packages/HSL/X5ozr/deps/usr/lib/libhsl_ma97.dylib, 0x0001): Library not loaded: @rpath/libblastrampoline.5.dylib
    Referenced from: /Users/administrator/.julia/packages/HSL/X5ozr/deps/usr/lib/libhsl_ma97.0.dylib
    Reason: tried: '/Users/administrator/actions-runner/_work/_tool/julia/1.6.7/x64/lib/julia/julia/libblastrampoline.5.dylib' (no such file), '/Users/administrator/actions-runner/_work/_tool/julia/1.6.7/x64/lib/julia/libblastrampoline.5.dylib' (no such file), '/Users/administrator/actions-runner/_work/_tool/julia/1.6.7/x64/bin/../lib/libblastrampoline.5.dylib' (no such file), '/usr/local/lib/libblastrampoline.5.dylib' (no such file), '/usr/lib/libblastrampoline.5.dylib' (no such file)
  Stacktrace:
    [1] Ma97_Control{Float64}(; print_level::Int64, unit_diagnostics::Int64, unit_error::Int64, unit_warning::Int64)
      @ HSL ~/.julia/packages/HSL/X5ozr/src/hsl_ma97.jl:115
    [2] Ma97_Control
      @ ~/.julia/packages/HSL/X5ozr/src/hsl_ma97.jl:90 [inlined]
    [3] ma97_csc(n::Int64, colptr::Vector{Int32}, rowval::Vector{Int32}, nzval::Vector{Float64}; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
      @ HSL ~/.julia/packages/HSL/X5ozr/src/hsl_ma97.jl:327
    [4] ma97_csc
      @ ~/.julia/packages/HSL/X5ozr/src/hsl_ma97.jl:327 [inlined]

The tests are passing with julia 1.7 and nightly.

amontoison commented 2 years ago

Did you compile it on Mac? The extension of the shared library is dylib. I also don't understand why it's linked with libblastrampoline, it should use lopenblas for Julia v1.6. Can you add the main version of HSL.jl and test again?

amontoison commented 2 years ago

Sorry, I didn't see that you added CI scripts... I suppose that Ma97 was not recompiled on the M1 when you changed the Julia version. I fixed this issue (https://github.com/JuliaSmoothOptimizers/HSL.jl/pull/140) but we need a new release of HSL.jl

amontoison commented 2 years ago

Can you open a PR in HSL.jl to do a new release?

geoffroyleconte commented 2 years ago

Thanks @amontoison !