JuliaSmoothOptimizers / RipQP.jl

MIT License
29 stars 5 forks source link

Update compat Krylov 0.9 #270

Closed geoffroyleconte closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.79% // Head: 82.52% // Decreases project coverage by -0.26% :warning:

Coverage data is based on head (2aa0d66) compared to base (ba493a9). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ========================================== - Coverage 82.79% 82.52% -0.27% ========================================== Files 58 58 Lines 3376 3376 ========================================== - Hits 2795 2786 -9 - Misses 581 590 +9 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/iterations/solvers/Krylov\_utils.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvc29sdmVycy9Lcnlsb3ZfdXRpbHMuamw=) | `53.90% <ø> (ø)` | | | [src/iterations/centrality\_corr.jl](https://codecov.io/gh/JuliaSmoothOptimizers/RipQP.jl/pull/270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2l0ZXJhdGlvbnMvY2VudHJhbGl0eV9jb3JyLmps) | `76.05% <0.00%> (-12.68%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

geoffroyleconte commented 1 year ago

@dpo @amontoison any idea why the tests with the M1 fail because of HSL? I don't think this is linked to this PR when looking at the error message.

amontoison commented 1 year ago

Dominique updated environnement variables related to compilers on the Mac directly. We need to update all CI scripts that test HSL solvers on the M1. You probably just need to copy the new YAML file: https://github.com/JuliaSmoothOptimizers/HSL.jl/blob/main/.github/workflows/CI_M1.yml

@tmigot It also concerns you.

geoffroyleconte commented 1 year ago

Thank you!