search

JuliaSmoothOptimizers / RipQP.jl

MIT License
29 stars 5 forks source link

Support the last release of CUDA.jl #290

Closed amontoison closed 6 months ago

geoffroyleconte commented 6 months ago

Thanks @amontoison, any reason why you removed the @views macro and used view instead? I used this macro a lot in other portions of the code.

amontoison commented 6 months ago

Thanks @amontoison, any reason why you removed the @views macro and used view instead? I used this macro a lot in other portions of the code.

@views is working well on CPU arrays but with GPU arrays the dispatch for this macro is not optimized and the compiler generates inefficient code.

amontoison commented 6 months ago

Thank you! Do you know if @views will be optimized in later releases? I like using this macro in other parts of the code because it improves readibility.

I don't know if we will have better support in the future. :( I'm just sure that it's not a priority for now because view is working well.

amontoison commented 6 months ago

@geoffroyleconte @dpo You have a new build buildkite/ripqp-dot-jl, it will run the tests dedicated to RipQP.jl + CUDA.jl in test/gpu.jl.