JuliaSmoothOptimizers / RipQP.jl

MIT License
29 stars 5 forks source link

LLS solve #33

Closed geoffroyleconte closed 3 years ago

geoffroyleconte commented 3 years ago

Solve LLSModels with RipQP.

@dpo is this what you had in mind? Should I rename the solve function to riplls ?

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 (2d6b031) into master (bd9e511) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   87.35%   87.39%   +0.04%     
==========================================
  Files          13       13              
  Lines         917      920       +3     
==========================================
+ Hits          801      804       +3     
  Misses        116      116              
Impacted Files Coverage Δ
src/RipQP.jl 95.23% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd9e511...2d6b031. Read the comment docs.

dpo commented 3 years ago

Yes, this looks great! Thanks!

There's a failure in the documentation. The link

https://juliasmoothoptimizers.github.io/SolverCore.jl/dev/api/#SolverCore.GenericExecutionStats

should be

https://juliasmoothoptimizers.github.io/SolverCore.jl/dev/reference/#SolverCore.GenericExecutionStats

(should be fixed in a separate PR please).

dpo commented 3 years ago

That's not in a separate PR :-)

geoffroyleconte commented 3 years ago

@dpo I only rebased : https://github.com/JuliaSmoothOptimizers/RipQP.jl/pull/35