JuliaSmoothOptimizers / SolverBenchmark.jl

Benchmark tools for solvers
Other
23 stars 10 forks source link

Update stats constructor in tests #135

Closed tmigot closed 1 year ago

tmigot commented 1 year ago

There is also the following error in dummy_solver:

┌ Error: caught exception
│   e =
│    MethodError: no method matching adjoint(::SuiteSparse.SPQR.QRSparse{Float64, Int64})
│    Closest candidates are:
│      adjoint(::Union{QR, LinearAlgebra.QRCompactWY, QRPivoted}) at julia\stdlib\v1.8\LinearAlgebra\src\qr.jl:517
│      adjoint(::Union{Cholesky, CholeskyPivoted}) at julia\stdlib\v1.8\LinearAlgebra\src\cholesky.jl:558
│      adjoint(::SuiteSparse.CHOLMOD.Factor) at julia\stdlib\v1.8\SuiteSparse\src\cholmod.jl:340
│      ...
└ @ SolverBenchmark SolverBenchmark.jl\src\run_solver.jl:155
codecov[bot] commented 1 year ago

Codecov Report

Base: 75.47% // Head: 77.07% // Increases project coverage by +1.59% :tada:

Coverage data is based on head (e67c89c) compared to base (3ce9896). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== + Coverage 75.47% 77.07% +1.59% ========================================== Files 12 12 Lines 314 314 ========================================== + Hits 237 242 +5 + Misses 77 72 -5 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/SolverBenchmark.jl/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/run\_solver.jl](https://codecov.io/gh/JuliaSmoothOptimizers/SolverBenchmark.jl/pull/135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3J1bl9zb2x2ZXIuamw=) | `82.50% <0.00%> (+12.50%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dpo commented 1 year ago

There is also the following error in dummy_solver:

dummy_solver assumes that J is dense. Maybe that has changed?

Also, have to run the docs manually to find the error in the log files.

tmigot commented 1 year ago

Since, some update of ADNLPModels the matrix is now sparse... Maybe we should move with this issue https://github.com/JuliaSmoothOptimizers/SolverCore.jl/issues/36 to avoid maintaining various dummy_solver everywhere?

tmigot commented 1 year ago

The issue with the documentation came from a new release of Plots.jl https://github.com/JuliaSmoothOptimizers/BenchmarkProfiles.jl/issues/89

dpo commented 1 year ago

Since, some update of ADNLPModels the matrix is now sparse... Maybe we should move with this issue JuliaSmoothOptimizers/SolverCore.jl#36 to avoid maintaining various dummy_solver everywhere?

Sure.

tmigot commented 1 year ago

@dpo I added the SolverCore.dummy_solver, so that no error messages appear in the tests.