search

JuliaSmoothOptimizers / SolverTools.jl

Tools for developing nonlinear optimization solvers.
Other
26 stars 18 forks source link

Support DataFrames 0.22 #155

Closed mohamed82008 closed 3 years ago

mohamed82008 commented 3 years ago

This PR adds 0.22 to the compat versions of DataFrames.

codecov[bot] commented 3 years ago

Codecov Report

Merging #155 (8309690) into master (0d5e4c4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          10       10           
  Lines         261      261           
=======================================
  Hits          237      237           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d5e4c4...8309690. Read the comment docs.

mohamed82008 commented 3 years ago

DataFrames 0.22 was used in the tests https://github.com/JuliaSmoothOptimizers/SolverTools.jl/runs/2106616866#step:5:20.

abelsiqueira commented 3 years ago

Thanks @mohamed82008. I'll prepare a release.

abelsiqueira commented 3 years ago

By the way, has DataFrames 0.22 been out long? Our CompatHelper should have picked it up.

mohamed82008 commented 3 years ago

Ya it's been a while. I don't know why CompatHelper hasn't picked it up.

abelsiqueira commented 3 years ago

I found out why. There was no activity for over 2 months, and the Action turned off.