search

JuliaSmoothOptimizers / SolverTools.jl

Tools for developing nonlinear optimization solvers.
Other
26 stars 18 forks source link

Move CUTEst from REQUIRE to test/REQUIRE #43

Closed abelsiqueira closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 69.463% when pulling eec007023bebbff10ca2c88f9feac61c18f8f502 on abelsiqueira:require-cutest into 2bc2d180a82ecea68a9d112b393e95baa0cbd697 on JuliaSmoothOptimizers:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 69.463% when pulling eec007023bebbff10ca2c88f9feac61c18f8f502 on abelsiqueira:require-cutest into 2bc2d180a82ecea68a9d112b393e95baa0cbd697 on JuliaSmoothOptimizers:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 69.463% when pulling eec007023bebbff10ca2c88f9feac61c18f8f502 on abelsiqueira:require-cutest into 2bc2d180a82ecea68a9d112b393e95baa0cbd697 on JuliaSmoothOptimizers:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 69.463% when pulling eec007023bebbff10ca2c88f9feac61c18f8f502 on abelsiqueira:require-cutest into 2bc2d180a82ecea68a9d112b393e95baa0cbd697 on JuliaSmoothOptimizers:master.

dpo commented 6 years ago

In the same vein, I've been wondering if we could eliminate BenchmarkProfiles.jl from the requirements and only export the benchmark functions if it's installed. We could use Requires.jl for that. Something like

Using requires
export profile_solvers

profile_solvers(stats :: Dict{Symbol, Array{Int,2}}; kwargs...) = error("BenchmarkProfiles is not installed")

@require BenchmarkProfiles begin
  function profile_solvers(stats :: Dict{Symbol, Array{Int,2}}; kwargs...)
    # our current function
  end
end
abelsiqueira commented 6 years ago

Created an issue to handle it later. Doesn't seem hard, though.