search

JuliaSmoothOptimizers / SolverTools.jl

Tools for developing nonlinear optimization solvers.
Other
26 stars 18 forks source link

Introduce logging #56

Closed dpo closed 6 years ago

abelsiqueira commented 6 years ago

I'm not sure how the logging is supposed to be used. Is it to be created when calling the optimizer, outside Optimize.jl - like the examples? Also, lbfgslogger is inside lbfgs.jl, but trunklogger is not inside trunk.jl.

dpo commented 6 years ago

There it is. Sorry for the confusion. Yes, logging is supposed to be set up as in the examples. It's turned off by default but it's more flexible than a verbose argument that has to be propagated.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-7.1%) to 73.519% when pulling 60f99e954f4cb4b0652d2029ebae98f6bd1784b6 on new-logging into fb6fee07f28410890b35766a0879ae15545cc800 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.4%) to 77.281% when pulling 5558eaa939e8af87f16b884d6378a138bf25c4fb on new-logging into fb6fee07f28410890b35766a0879ae15545cc800 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.4%) to 77.281% when pulling 5558eaa939e8af87f16b884d6378a138bf25c4fb on new-logging into fb6fee07f28410890b35766a0879ae15545cc800 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.4%) to 77.281% when pulling 5558eaa939e8af87f16b884d6378a138bf25c4fb on new-logging into fb6fee07f28410890b35766a0879ae15545cc800 on master.

dpo commented 6 years ago

Same old gcc error. I think this can safely be labeled as good to go.

abelsiqueira commented 6 years ago

Manually rebased and merged. Thanks.