Closed abelsiqueira closed 5 years ago
Do we still need the AbstractExecutionStats stuff, now that we are using DataFrames?
This works for me, although there's a lot of output when I include examples/benchmark.jl
due to the default logging. We can resolve that in another PR though.
Do we still need the AbstractExecutionStats stuff, now that we are using DataFrames?
Do you mean (1) remove all *ExecutionStats; or (2) We should have only one
ExecutionStats` and no abstract anymore.
1- I think it's good to have an ExecutionStats
because the solver outputs more than is put in the DataFrame, and this way the output can be relied upon;
2- Having one ExecutionStats seems better, I don't think we'll have use for more than one.
On the amount of logging, I also find annoying, but it seems better to leave for another PR.
1- I think it's good to have an ExecutionStats because the solver outputs more than is put in the DataFrame, and this way the output can be relied upon;
Do you mean the solution, the multipliers, etc.?
Yes
Thank you!
solve_problems
returns aDataFrame
bmark_solvers
return a dictionary ofsolver => DataFrame
profile_solvers
receives a dictionary ofsolver => DataFrame
Example on
examples/benchmark.jl
.