JuliaSmoothOptimizers / SolverTools.jl

Tools for developing nonlinear optimization solvers.
Other
26 stars 18 forks source link

Benchmark uses DataFrames #71

Closed abelsiqueira closed 5 years ago

abelsiqueira commented 5 years ago

Example on examples/benchmark.jl.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 70.365% when pulling 45a08a4a544d2cce3ba40acaa6e0b47cc4478157 on abelsiqueira:dataframes into be0a6198773d8529f4a4d7485c10eed5efbd2f85 on JuliaSmoothOptimizers:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 70.365% when pulling 66dbc6a62951ad70f5d3d3410b09f19a6e702480 on abelsiqueira:dataframes into be0a6198773d8529f4a4d7485c10eed5efbd2f85 on JuliaSmoothOptimizers:master.

dpo commented 5 years ago

Do we still need the AbstractExecutionStats stuff, now that we are using DataFrames?

dpo commented 5 years ago

This works for me, although there's a lot of output when I include examples/benchmark.jl due to the default logging. We can resolve that in another PR though.

abelsiqueira commented 5 years ago

Do we still need the AbstractExecutionStats stuff, now that we are using DataFrames?

Do you mean (1) remove all *ExecutionStats; or (2) We should have only oneExecutionStats` and no abstract anymore.

1- I think it's good to have an ExecutionStats because the solver outputs more than is put in the DataFrame, and this way the output can be relied upon; 2- Having one ExecutionStats seems better, I don't think we'll have use for more than one.

On the amount of logging, I also find annoying, but it seems better to leave for another PR.

dpo commented 5 years ago

1- I think it's good to have an ExecutionStats because the solver outputs more than is put in the DataFrame, and this way the output can be relied upon;

Do you mean the solution, the multipliers, etc.?

abelsiqueira commented 5 years ago

Yes

dpo commented 5 years ago

Thank you!