Drop all IERS EOP data functions and use EarthOrientation.jl

JuliaSpace / SatelliteToolbox.jl

A toolbox for satellite analysis written in julia language.

MIT License

250 stars 33 forks source link

Drop all IERS EOP data functions and use EarthOrientation.jl #2

Closed ronisbr closed 8 months ago

ronisbr commented 6 years ago

The EarthOrientation.jl package already provide the feature to download and interpolate data from IERS. I need to test if the performance is equal or better and then drop the functions related to it from SatelliteToolbox.jl.

helgee commented 6 years ago

I did some benchmarking. Currently the functions in EarthOrientation.jl are a bit slower.

SatelliteToolbox.jl: ~30 ns
EarthOrientation.jl (UT1-UTC): ~70 ns
EarthOrientation.jl (others): ~60 ns

But they also use a more sophisticated interpolation scheme, i.e. Akima interpolation, and UT1-UTC is also more "correct", i.e. it is being interpolated as UT1-TAI which avoids jumps and correctly handles leap seconds.

Would that be acceptable for SatelliteToolbox.jl from a performance point of view?

helgee commented 6 years ago

Okay, new performance results after some tweaks 😄

EarthOrientation.jl (UT1-UTC): ~38 ns (edit)
EarthOrientation.jl (others): ~26 ns

ronisbr commented 6 years ago

Hi @helgee ,

This is perfect! I will try to change the package to use EarthOrientation.jl in the following weeks.

Thanks for the info!

ronisbr commented 8 months ago

The package is not updated since 2021 and the tests are failing. Now that we rewrote the entire SatelliteToolbox.jl ecosystem, I think it is safer to keep with the current implementation.