Closed ThatcherC closed 4 years ago
Totals | |
---|---|
Change from base Build 240: | 0.03% |
Covered Lines: | 1813 |
Relevant Lines: | 2872 |
Hi @ThatcherC!
This is awesome, thank you very much! I'll merge as soon as the tests are completed.
It is nice to see someone using this package in a Raspberry Pi :) I would have thought that it would not be able to compile it. Is it possible, just for curiosity, to tell me which model are you using?
Hey @ronisbr - thanks! Glad to have contributed to the project- it's an amazing resource. I was using SatelliteToolbox.jl on a Raspberry Pi 3B+. Julia is slow to start on that platform, and all programs run slowly at first, though I think this is all due to Julia's JIT compiler. Once it's up and running though, Julia+SatelliteToolbox work just fine on the Pi.
I don't know if the Pi is a platform you're interested in targeting, but it could be useful to add a 32-bit Debian option to the test running you have set up on this repo. For now though, it all seems to work perfectly well with this new patch.
This PR fixes an error where calling DatetoJD on a Julia DateTime object would fail on a 32-bit system (a Raspberry Pi in my case). The error had to do with the use of the
Int
type in some function definitions insrc/time/julian_day.jl
andsrc/time/time.jl
, which resolves to Int32 on a 32-bit machine. DateTime.year(), on the other hand, is an Int64, which causes a type error. My fix changes the function definitions in question to use the more permissiveInteger
type.I also added a unit test that addresses the bug I fixed!