search

JuliaSpace / SatelliteToolbox.jl

A toolbox for satellite analysis written in julia language.
MIT License
248 stars 33 forks source link

Wrong docstring for rv_to_mean_elements_j2osc #67

Closed ThatcherC closed 2 years ago

ThatcherC commented 2 years ago

It looks like the docstring for rv_to_mean_elements_j2osc is pretty much a duplication of rv_to_mean_elements_sgp4 despite the functions being very different. For example, the j2osc docstring references BSTAR and SGP4_GravCte, neither of which are used in the j2osc function and neither of which are valid arguments to the j2osc function.

https://github.com/JuliaSpace/SatelliteToolbox.jl/blob/32effb7a08a4cf755832a303c9b2fd795fe3384b/src/orbit/mean_elements/j2osc.jl#L21-L60

ronisbr commented 2 years ago

You are 100% right! I will fix it.