JuliaSpaceMissionDesign / FrameTransformations.jl

A modern, high-performance and comprehensive set of tools for transformations between any standard and user-defined reference frame.
MIT License
19 stars 3 forks source link

Loss of accuracy of some tests #26

Closed andreapasquale94 closed 3 months ago

andreapasquale94 commented 10 months ago

The last update reveals a loss of accuracy in some transformations. I had to change the following test tolerance to 1e-4 from 1e-6.

https://github.com/JuliaSpaceMissionDesign/FrameTransformations.jl/blob/8a6f46a93864eee79fbd2d6e0f8fc3620409ed30/test/Orient/moon.jl#L60

https://github.com/JuliaSpaceMissionDesign/FrameTransformations.jl/blob/8a6f46a93864eee79fbd2d6e0f8fc3620409ed30/test/Orient/moon.jl#L67

The reason should be investigated. Maybe due to the change from Calceph to Ephemerides in the tests?

MicheleCeresoli commented 10 months ago

Some tests are also failing in the axes and points testsets when using Ephemerides.jl instead of Calceph, however this happens sporadically.

andreapasquale94 commented 3 months ago

Outdated.