search

JuliaSpaceMissionDesign / FrameTransformations.jl

A modern, high-performance and comprehensive set of tools for transformations between any standard and user-defined reference frame.
MIT License
19 stars 3 forks source link

19 add legacy inertial frames #28

Closed andreapasquale94 closed 10 months ago

andreapasquale94 commented 11 months ago

Reopen new pull request for legacy frames starting from last dev (eop fixes). Continue from #21.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (ebd797a) 87.45% compared to head (443b651) 86.23%.

Files Patch % Lines
src/Frames/Definitions/common.jl 57.44% 20 Missing :warning:
src/Orient/common.jl 82.22% 8 Missing :warning:
src/Orient/Earth/additional.jl 50.00% 3 Missing :warning:
src/Orient/Earth/builders.jl 98.63% 1 Missing :warning:
src/Orient/Earth/iers.jl 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #28 +/- ## ========================================== - Coverage 87.45% 86.23% -1.22% ========================================== Files 35 33 -2 Lines 2391 2114 -277 ========================================== - Hits 2091 1823 -268 + Misses 300 291 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreapasquale94 commented 11 months ago

I would say we are ready to merge this now! @MicheleCeresoli

Improved documentation and test coverage TODO in another thread.