search

JuliaSparse / Pardiso.jl

Calling the PARDISO library from Julia
Other
100 stars 27 forks source link

Uncommitted changes in src/Pardiso.jl ? #5

Closed gasagna closed 8 years ago

gasagna commented 8 years ago

Hi, when cloning your repo the file src/Pardiso.jl does not appear to get pulled. git status shows that that file is modified but not staged for commit.

Or I am missing something?

Thanks

P.S.

I am trying to get this package working under OSX

KristofferC commented 8 years ago

I don't believe that is a problem with the repo but more that you have made a local change to src/Pardiso.jl. If you want to discard that change you can do git checkout -- src/Pardiso.jl.

KristofferC commented 8 years ago

Btw, I sort of forgot about this package. I'm better at julia now than when I wrote this so I will look it over and see if some stuff can be improved.

gasagna commented 8 years ago

That seems strange. When cloning the repo as git clone https://github.com/JuliaSparse/Pardiso.jl.git, the file src/Pardiso.jl does not show up in the file manager. Same when downloading a zip file from the front page.

KristofferC commented 8 years ago 
21:00 $ git clone https://github.com/JuliaSparse/Pardiso.jl.git
Cloning into 'Pardiso.jl'...
remote: Counting objects: 235, done.
remote: Total 235 (delta 0), reused 0 (delta 0), pack-reused 235
Receiving objects: 100% (235/235), 45.77 KiB | 0 bytes/s, done.
Resolving deltas: 100% (126/126), done.
Checking connectivity... done.
✔ ~ 
21:00 $ cd Pardiso.jl/
✔ ~/Pardiso.jl [master|✔] 
21:00 $ ls src/
mkl_pardiso.jl  pardiso.jl  Pardiso.jl
✔ ~/Pardiso.jl [master|✔]
gasagna commented 8 years ago 
davide@vega - ~$: git clone https://github.com/JuliaSparse/Pardiso.jl.git
Cloning into 'Pardiso.jl'...
remote: Counting objects: 235, done.
remote: Total 235 (delta 0), reused 0 (delta 0), pack-reused 235
Receiving objects: 100% (235/235), 45.77 KiB | 0 bytes/s, done.
Resolving deltas: 100% (126/126), done.
Checking connectivity... done.
davide@vega - ~$: cd Pardiso.jl
davide@vega - Pardiso.jl$: ls
LICENSE.md  README.md   REQUIRE     src/        test/
davide@vega - Pardiso.jl$: cd src/
davide@vega - src$: ls
mkl_pardiso.jl  pardiso.jl

This does not make sense to me. Sorry for the noise....

KristofferC commented 8 years ago

Hmm, after seeing that, I would suggest exorcism.

gasagna commented 8 years ago

Works OK on another machine.. I just have to do this exorcism now... Will investigate, and close it now.

Thanks..

gasagna commented 8 years ago

This behaviour is due to the OSX filesystem being case independent. When cloning the repo, src/Pardiso.jl gets downloaded first and then overwritten by src/pardiso.jl, showing uncommited modifications. It can be easily resolved by changing the name of src/pardiso.jl to something else.

Nice exorcism...

KristofferC commented 8 years ago

Aah! Ok, I will change the name of pardiso.jl.

gasagna commented 8 years ago

Thanks!