JuliaSparse / SparseArrays.jl

SparseArrays.jl is a Julia stdlib
https://sparsearrays.juliasparse.org/
Other
92 stars 52 forks source link

cast to Float64 directly instead of using float #521

Closed SobhanMP closed 8 months ago

SobhanMP commented 8 months ago

Does this make sense?

Closes #515

julia> using SparseArrays, ForwardDiff, LinearAlgebra
julia> A = ForwardDiff.Dual.(sprand(10, 10, 0.1));
julia> qr(A)
ERROR: MethodError: no method matching Float64(::ForwardDiff.Dual{Nothing, Float64, 0})
The type `Float64` exists, but no method is defined for this combination of argument types when trying to construct it.
codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.26%. Comparing base (a5e95ec) to head (0c8f8f3).

Files Patch % Lines
src/solvers/spqr.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #521 +/- ## ======================================= Coverage 84.26% 84.26% ======================================= Files 12 12 Lines 9122 9122 ======================================= Hits 7687 7687 Misses 1435 1435 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rayegun commented 8 months ago

What happens in the complex case?

SobhanMP commented 8 months ago

What happens in the complex case?

The same as it used to do.