search

JuliaSparse / SuiteSparseGraphBLAS.jl

Sparse, General Linear Algebra for Graphs!
MIT License
103 stars 17 forks source link

Assorted mul rules #31

Closed rayegun closed 3 years ago

rayegun commented 3 years ago

WIP PR for some additional rules. I believe these are correct.

Note: Larger matrices, especially dense ones, run into floating point issues for isapprox. I'm not sure if I should be bothered by that or not.

codecov-commenter commented 3 years ago

Codecov Report

Merging #31 (db79686) into master (09d22f5) will increase coverage by 0.69%. The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   33.18%   33.88%   +0.69%     
==========================================
  Files          34       34              
  Lines        2751     2783      +32     
==========================================
+ Hits          913      943      +30     
- Misses       1838     1840       +2
Impacted Files Coverage Δ
src/descriptors.jl 77.77% <0.00%> (-1.26%) :arrow_down:
src/operations/transpose.jl 56.52% <ø> (ø)
src/operations/map.jl 63.49% <43.75%> (+1.95%) :arrow_up:
src/chainrules/mulrules.jl 100.00% <100.00%> (ø)
src/operations/ewise.jl 36.44% <0.00%> (+1.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09d22f5...db79686. Read the comment docs.

rayegun commented 3 years ago

I'm actually just going to merge this since I believe they're right.