JuliaSparse / SuiteSparseGraphBLAS.jl

Sparse, General Linear Algebra for Graphs!
MIT License
102 stars 17 forks source link

enable testing on 1.3 #8

Closed KristofferC closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #8   +/-   ##
======================================
  Coverage    51.2%   51.2%           
======================================
  Files          25      25           
  Lines         541     541           
======================================
  Hits          277     277           
  Misses        264     264

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ead094f...a0bf545. Read the comment docs.

abhinavmehndiratta commented 5 years ago

What is the purpose of testing on 1.3 ?

KristofferC commented 5 years ago

This package failed when running the tests for this package on the upcoming 1.3 (https://gist.github.com/KristofferC/47577ec5ad3b4418fd98f20bc3d91957#file-suitesparsegraphblas-log) so I wanted to test if this also happened on CI. But it seems fine here...

abhinavmehndiratta commented 5 years ago

This package failed when running the tests for this package on the upcoming 1.3 (https://gist.github.com/KristofferC/47577ec5ad3b4418fd98f20bc3d91957#file-suitesparsegraphblas-log) so I wanted to test if this also happened on CI. But it seems fine here...

Strange, has this happened with any other packages ?

KristofferC commented 5 years ago

No. It looks like choose_download(download_info) returned nothing which happens if nothing matches the platform:

https://github.com/JuliaPackaging/BinaryProvider.jl/blob/241bdc4bd78e8daf73244278e076d8588394a3af/src/PlatformNames.jl#L746-L748.

So it might be that the machine I am running on does not have a corresponding platform to download the library.

abhinavmehndiratta commented 5 years ago

So it might be that the machine I am running on does not have a corresponding platform to download the library.

Oh okay, makes sense. I should probably add a try catch block there.