search

JuliaStats / DataArrays.jl

DEPRECATED: Data structures that allow missing values
Other
53 stars 50 forks source link

Add missing LineNumberNode to @swappable call (fixes #257) #259

Closed getzdan closed 7 years ago

getzdan commented 7 years ago

There has been some change to Julia in the macrocall AST, adding the LineNumberNode. Unless there is another change to Julia, some packages using :macrocall expression generation will break.

nalimilan commented 7 years ago

Thanks. Indeed this fixes loading the package, but I wonder whether the test failure may be related: the path between #= and =# is suspicious.

Booleans: Error During Test
  Expression evaluated to non-Boolean
  Expression: any(#= C:\Users\appveyor\.julia\v0.7\DataArrays\test\booleans.jl:15 =# @data([NA, 1, 2]) .== 1) == true
       Value: NA
getzdan commented 7 years ago

Don't think the test error is related. Actually, it seems to me the test should Fail (but not error), as 1 == NA should be NA. But this discussion is for the other issue.

getzdan commented 7 years ago

You are right .== is acting weird:

julia> (@data [NA, 1, 2]) .== 1
0-dimensional DataArrays.DataArray{Bool,0}:
NA
nalimilan commented 7 years ago

I guess we can still merge this (after updating the version check) and continue debugging, as it's always easier to debug a package that can be loaded.

ararslan commented 7 years ago

Thanks for figuring this out!

nalimilan commented 7 years ago

The failure actually comes from a change in Base, see https://github.com/JuliaLang/julia/pull/22019 and https://github.com/JuliaLang/julia/pull/22130.