search

JuliaStats / Distributions.jl

A Julia package for probability distributions and associated functions.
Other
1.08k stars 410 forks source link

Fix failing tests on 1.11-beta #1862

Closed andreasnoack closed 1 month ago

andreasnoack commented 1 month ago

We need a slightly larger sample size when testing DiscreteNonParametric to ensure that empirical moments are close enough to theoretical moments.

The semicircle tests were also vulnerable to changes to the drawn variates so I've switched from MersenneTwister to StableRNGs.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.87%. Comparing base (f852803) to head (57daf6a). Report is 2 commits behind head on andreasnoack-patch-1.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## andreasnoack-patch-1 #1862 +/- ## ======================================================== - Coverage 85.96% 85.87% -0.09% ======================================================== Files 144 144 Lines 8647 8636 -11 ======================================================== - Hits 7433 7416 -17 - Misses 1214 1220 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreasnoack commented 1 month ago

This one was against my other PR. I think we should cherry-pick what's here and go with your PR instead.