search

JuliaStats / Distributions.jl

A Julia package for probability distributions and associated functions.
Other
1.1k stars 414 forks source link

Update CI: No nightly tests, improve macOS CI setup + use julia-actions/cache #1863

Closed devmotion closed 3 months ago

devmotion commented 4 months ago

In this draft I see if one can achieve something like #1861 without running tests twice if no prerelease is available. Additionally, This PR removes the nightly tests (see #1861), includes a fix for the mac CI setup (see #1856), and switches to julia-actions/cache for caching.

Edit: The PR also includes https://github.com/JuliaStats/Distributions.jl/pull/1862 which fixes tests on Julia 1.11-beta1 (see https://github.com/JuliaStats/Distributions.jl/pull/1862#issuecomment-2133916510).

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.96%. Comparing base (f852803) to head (8aee234).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1863 +/- ## ======================================= Coverage 85.96% 85.96% ======================================= Files 144 144 Lines 8647 8647 ======================================= Hits 7433 7433 Misses 1214 1214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreasnoack commented 4 months ago

without running tests twice if no prerelease is available.

I don't think that will happen. There will only be a single run for julia@1 but that run might be a prerelease, see https://github.com/JuliaStats/Distributions.jl/actions/runs/9250768369/job/25444947763?pr=1862, and maybe that is not what we want.

devmotion commented 4 months ago

There will only be a single run for julia@1 but that run might be a prerelease,

Indeed, my comment above was incorrect: I was already assuming that we would want to change that PR such that we continue testing with the latest stable release.

andreasnoack commented 4 months ago

I'm wondering if it's worthwhile to add all the complexity to the CI.yml file for this, though. I think testing prereleases in dedicated PRs is reasonable. It requires a little effort but not much.

devmotion commented 4 months ago

I agree, in particular given that tests seem to fail on the prerelease as well (and the fact that the PR in its current state actually doesn't skip the duplicate runs).