search

JuliaStats / Distributions.jl

A Julia package for probability distributions and associated functions.
Other
1.08k stars 410 forks source link

Rename `ValueSupport` subtypes to more specific names #1870

Open juliohm opened 2 weeks ago

juliohm commented 2 weeks ago

Currently the subtypes of ValueSupport are Discrete and Continuous as described here:

https://github.com/JuliaStats/Distributions.jl/blob/b356da03a189d023cdb8467c61806a8a11dcb262/docs/src/types.md?plain=1#L34-L50

These names are too generic to export, and conflict with other mathematical packages.

Would you be ok with renaming these two to DiscreteSupport and ContinuousSupport?

I can work on a PR that includes a deprecation warning.

devmotion commented 2 weeks ago

Is there an actual problem/conflict with some other package? My initial feeling is that we should only make such a change if it's worth it.