search

JuliaStats / Distributions.jl

A Julia package for probability distributions and associated functions.
Other
1.11k stars 416 forks source link

Passing ArrayViews to functions #225

Closed nfoti closed 10 years ago

nfoti commented 10 years ago

It looks like ArrayViews cannot be passed to functions in Distributions.jl. Was this done on purpose or is it just that no one has had time to implement it?

Thanks.

johnmyleswhite commented 10 years ago

This seems accidental to me. For inputs that aren't being mutated, we should generally be able to accept AbstractArray as an input.

simonbyrne commented 10 years ago

@nfoti Yes, they should work. Which methods were you having trouble with?

nfoti commented 10 years ago

I know that logpdf for multivariate Gaussians were giving an error, there could be more though.

On Wed, May 7, 2014 at 10:58 AM, Simon Byrne notifications@github.comwrote:

@nfoti https://github.com/nfoti Yes, they should work. Which methods were you having trouble with?

— Reply to this email directly or view it on GitHubhttps://github.com/JuliaStats/Distributions.jl/issues/225#issuecomment-42460839 .

lindahua commented 10 years ago

This should have been fixed with latest refactoring. Feel free to reopen if there remains problems.