JuliaStats / GLM.jl

Generalized linear models in Julia
Other
593 stars 114 forks source link

compat fixes for Julia v1.8 #459

Closed dkarrasch closed 2 years ago

dkarrasch commented 2 years ago

Depends on https://github.com/JuliaLang/julia/pull/41640/.

Needs to be adjusted regarding the exact DEV-version number.

codecov-commenter commented 2 years ago

Codecov Report

Merging #459 (2e2c3f8) into master (ac46c09) will decrease coverage by 0.55%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   84.56%   84.01%   -0.56%     
==========================================
  Files           6        7       +1     
  Lines         784      807      +23     
==========================================
+ Hits          663      678      +15     
- Misses        121      129       +8     
Impacted Files Coverage Δ
src/GLM.jl 50.00% <50.00%> (ø)
src/linpred.jl 76.31% <100.00%> (-0.27%) :arrow_down:
src/glmfit.jl 78.36% <0.00%> (-1.78%) :arrow_down:
src/lm.jl 96.74% <0.00%> (+0.05%) :arrow_up:
src/glmtools.jl 82.70% <0.00%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac46c09...2e2c3f8. Read the comment docs.

dkarrasch commented 2 years ago

CI should be re-run in a few hours to make sure the tests run on a sufficiently up-to-date nightly version.

palday commented 2 years ago

@dkarrasch there's a doctest failure from a pivoted Cholesky being used where the non pivoted should be used. I've kicked off the CI again, but I'll take a closer look later if it fails.

dkarrasch commented 2 years ago

You're welcome!