search

JuliaStats / GLM.jl

Generalized linear models in Julia
Other
584 stars 114 forks source link

use `StatsModels.isnested` instead of defining new `issubmodel` func #462

Closed kleinschmidt closed 2 years ago

kleinschmidt commented 2 years ago

This just replaces the function called issubmodel with a method for StatsModels.isnested in order to provide support for StatsModels.lrtest and other goodies that assume that API. issubmodel is deprecated and otherwise there are no changes to the code.

edit: I have not bumped the version. I'll open a new PR for that once this is merged.

codecov-commenter commented 2 years ago

Codecov Report

Merging #462 (c16728f) into master (8da427b) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head c16728f differs from pull request most recent head 45fc932. Consider uploading reports for the commit 45fc932 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files           7        7           
  Lines         807      807           
=======================================
  Hits          678      678           
  Misses        129      129
Impacted Files Coverage Δ
src/ftest.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8da427b...45fc932. Read the comment docs.