search

JuliaStats / GLM.jl

Generalized linear models in Julia
Other
593 stars 114 forks source link

r2 for GLM #475

Closed mousum-github closed 2 years ago

mousum-github commented 2 years ago

The documentation says that the r2 function computes R² of a linear model or pseudo-R² of a generalized linear model. But if we call r2 with any glm fitted model, it throws an error. I have come across a lot of debates on r2, nulldeviance etc for GLM in the forum. It would be better if we remove the pseudo-R² part from the documentation until the same is implemented for GLM.

nalimilan commented 2 years ago

Good catch. See https://github.com/JuliaStats/GLM.jl/pull/477.

nalimilan commented 2 years ago

Fixed by https://github.com/JuliaStats/GLM.jl/pull/479.