JuliaStats / GLM.jl

Generalized linear models in Julia
Other
593 stars 114 forks source link

Adding geometric distribution for GLM.jl #480

Closed ayushpatnaikgit closed 2 years ago

ayushpatnaikgit commented 2 years ago

The following is the summary of the changes in the following source files:

  1. In docs/src/index.md:
  1. In src/GLM.jl:
  1. In src/glmtools.jl:
  1. In test/runtests.jl:
codecov-commenter commented 2 years ago

Codecov Report

Merging #480 (633ed64) into master (42a0d04) will increase coverage by 0.16%. The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   85.12%   85.28%   +0.16%     
==========================================
  Files           7        7              
  Lines         827      836       +9     
==========================================
+ Hits          704      713       +9     
  Misses        123      123              
Impacted Files Coverage Δ
src/GLM.jl 50.00% <ø> (ø)
src/glmtools.jl 83.80% <94.11%> (+1.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42a0d04...633ed64. Read the comment docs.

nalimilan commented 2 years ago

It would be good to document where the numbers in the "Geometric LogLink" test set come from

I don't think we note this in the code usually, I think the implicit assumption is that values have been checked against R, either directly or indirectly (here, by checking against NegativeBinomial which was previously checked against R).

ViralBShah commented 2 years ago

Bumping this - what remains to merge?

nalimilan commented 2 years ago

Thanks!