JuliaStats / GLM.jl

Generalized linear models in Julia
Other
593 stars 114 forks source link

Readability improvement #482

Closed mousum-github closed 2 years ago

mousum-github commented 2 years ago

In this PR, to improve the readability of the GLM document, we have:

codecov-commenter commented 2 years ago

Codecov Report

Merging #482 (4b162c8) into master (42a0d04) will increase coverage by 2.31%. The diff coverage is n/a.

:exclamation: Current head 4b162c8 differs from pull request most recent head d7d384d. Consider uploading reports for the commit d7d384d to get more accurate results

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   85.12%   87.44%   +2.31%     
==========================================
  Files           7        7              
  Lines         827      900      +73     
==========================================
+ Hits          704      787      +83     
+ Misses        123      113      -10     
Impacted Files Coverage Δ
src/GLM.jl 66.66% <ø> (+16.66%) :arrow_up:
src/lm.jl 96.21% <0.00%> (-0.03%) :arrow_down:
src/glmfit.jl 81.25% <0.00%> (+2.50%) :arrow_up:
src/glmtools.jl 92.99% <0.00%> (+10.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42a0d04...d7d384d. Read the comment docs.

ViralBShah commented 2 years ago

Bump. Can we merge this? @nalimilan Aside from you who else might be good to ping?

ararslan commented 2 years ago

I have a suggested fix for a typo (GitHub won't let me apply it myself 🤔) but otherwise looks good to me. Thanks for the contribution!

kleinschmidt commented 2 years ago

@mousum-github if you enable "contributors can push changes to my branch" or something like that in the PR options, we can apply these changes before merging. Otherwise we'll have to wait on you to accept the suggestions.

ViralBShah commented 2 years ago

@mousum-github Can you please update the repo settings so that folks can directly edit the PR? Also would be great if the comments can be addressed and prepared for merging.

ayushpatnaikgit commented 2 years ago

Apologies, @ViralBShah @kleinschmidt Allow edits from maintainers isn't showing for this pull request (and the others that we've made). Any clues why this could be happening? It could be happening because we've made the PR from an Organization account https://github.community/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847/9

For the time being, shall I add the four of you as collaborators to the repo?

ViralBShah commented 2 years ago

Yes just add the others. Not necessary to add me.

mousum-github commented 2 years ago

Hi - I am aware that there is a lot of progress on all PRs in GLM including this. I was out of the station for the last couple of weeks. I will go through all comments and will do the necessary steps form tomorrow. I am sorry for the delay in response and any inconvenience caused due to my absence for an unusually long period.

ararslan commented 2 years ago

No problem at all! Thanks for your efforts here and I hope you enjoyed your time away.

ViralBShah commented 2 years ago

Should this be merged?

ViralBShah commented 2 years ago

Is this good to merge?

nalimilan commented 2 years ago

Thanks!