Closed kleinschmidt closed 1 year ago
Patch coverage: 97.52
% and project coverage change: +1.35
:tada:
Comparison is base (
9dc4d6b
) 87.39% compared to head (7f816d7
) 88.75%.:exclamation: Current head 7f816d7 differs from pull request most recent head ceae65f. Consider uploading reports for the commit ceae65f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Okay, I've double checked at least the ubuntu runs to make sure that statsmodels 0.7 was used and all tests are passing so I think this is good to go!
nightly failures are due to the "evaluated to nonboolean" change for @test_broken
We will tag 0.7 very soon (
probably todayahahaha good one...) with changes toFunctionTerm
that are breaking but do not directly affect anything that GLM itself uses. This PR should not be merged until 0.7 is tagged and CI can be run to ensure that nothing breaks in GLM, so I'll start this in draft mode and flip it out when it's time to check CI.Update: 0.7 is now released. I've added bumped the patch version here and also fixed a bug where we were defining our own
formula
function instead of creating a method forStatsModels.formula
.Update to teh update: based on #500, I re-based this on a commit before #339 was merged, targeting a "backport" branch called
v1
.